Skip to content

add tool to check if parameter validation is enabled - #13

Merged
SirCotare merged 2 commits into
mainfrom
validation_checking
Feb 17, 2025
Merged

add tool to check if parameter validation is enabled#13
SirCotare merged 2 commits into
mainfrom
validation_checking

Conversation

@SirCotare

@SirCotare SirCotare commented Feb 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

We need this to check for the annotations.

This is necessary because we changed create&update action tests to no longer run as @ApplicationTests. Therefore we get not bean validation done by Spring.

To we first check if the annotations are there and then validate the parameter with the standalone tool.

@Test
void isEnabled() {
    assertThatValidation().calling(
            sut.getClass(),
            "create",
            ArticleClassCreateAction.Parameter.class
    ).isEnabled();
}

@SirCotare SirCotare self-assigned this Feb 17, 2025
@SirCotare
SirCotare merged commit f78d5cf into main Feb 17, 2025
@SirCotare
SirCotare deleted the validation_checking branch February 17, 2025 13:07
ThoSap
ThoSap reviewed Feb 26, 2025
View reviewed changes

@ThoSap ThoSap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it disappears from my to review pull request overview on GitHub ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThoSap ThoSap ThoSap left review comments
@mmalfertheiner mmalfertheiner mmalfertheiner approved these changes

Assignees

@SirCotare SirCotare

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SirCotare @mmalfertheiner @ThoSap